This repository was archived by the owner on Mar 25, 2026. It is now read-only.
Added pre-requisites for building native modules on linux and updated native-node-modules.md#336
Closed
ttheshreeyasingh wants to merge 12 commits into
Closed
Added pre-requisites for building native modules on linux and updated native-node-modules.md#336ttheshreeyasingh wants to merge 12 commits into
ttheshreeyasingh wants to merge 12 commits into
Conversation
andybalaam
suggested changes
Apr 11, 2022
Member
andybalaam
left a comment
andybalaam
left a comment
There was a problem hiding this comment.
Nice work, with some small improvements needed, thanks!
andybalaam
approved these changes
Apr 20, 2022
Member
andybalaam
left a comment
andybalaam
left a comment
There was a problem hiding this comment.
Sorry for the delay re-reviewing. Just one small change left and we can merge this. Thank you for working on it!
andybalaam
suggested changes
Apr 20, 2022
Member
andybalaam
left a comment
andybalaam
left a comment
There was a problem hiding this comment.
Oops, I mean to click "Request changes" - just the Perl section needs changing.
Author
Sure, will make the required changes |
|
This change does not make sense. But more generally, all sections about sqlcipher should be removed since #334 has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added file
linux-requirements.mdinelement-desktop/docsand updatednative-node-modules.md, put the config part before the yarn start step for more clarity. Also added steps to install SQLCipher library in Adding Seshat for search in E2E encrypted rooms.Signed-off-by: Shreeya shreeya.singh@students.iiit.ac.in
This PR currently has no changelog labels, so will not be included in changelogs.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.