Skip to content

Allow modules to perform certain actions on EW#112

Closed
MidhunSureshR wants to merge 2 commits into
mainfrom
midhun/multiroom/actions-api
Closed

Allow modules to perform certain actions on EW#112
MidhunSureshR wants to merge 2 commits into
mainfrom
midhun/multiroom/actions-api

Conversation

@MidhunSureshR
Copy link
Copy Markdown
Member

@MidhunSureshR MidhunSureshR commented Oct 23, 2025

For eg: Open a room on element-web

@MidhunSureshR MidhunSureshR marked this pull request as ready for review October 23, 2025 07:27
@MidhunSureshR MidhunSureshR requested a review from a team as a code owner October 23, 2025 07:27
@MidhunSureshR MidhunSureshR requested review from dbkr and t3chguy October 23, 2025 07:27
* Open a room in element-web.
* @param roomId - id of the room to open
*/
openRoom: (roomId: string) => void;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not already covered by the Navigation API? If not would it not fit better there?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a function to navigate to a matrix.to link which we could use for the same thing but I'd rather include a separate method just to open rooms by room id. I was thinking eventually actions would have more methods like openThreadInRoom, openRightPanel and so on..

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but aren't those navigation actions?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on what navigation means. I interpreted it as being related to URLs since that's what the two existing methods do. If you interpret navigation as in navigating through the UI, then yes, it makes sense to include this there.

Copy link
Copy Markdown
Member

@t3chguy t3chguy Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough :)

@MidhunSureshR
Copy link
Copy Markdown
Member Author

superseded by #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants