Add ExtraApi#getVisibleRoomBySpaceKey#134
Merged
Merged
Conversation
dbkr
reviewed
Nov 21, 2025
Member
dbkr
left a comment
dbkr
left a comment
There was a problem hiding this comment.
One thought: is there a risk this could get out of sync? ie. if we passed a callback to get the rooms for a space when EW needed to know, would that be less data duplication?
Member
Author
|
@dbkr hmm, you're right there is less risk to be out of sync with the cb approach |
langleyd
reviewed
Nov 21, 2025
Member
Author
florianduros
force-pushed
the
florianduros/roomids-space-module
branch
from
3868aef to
4728aea
Compare
florianduros
changed the title
ExtraApi#setRoomIdsForSpaceExtraApi#getVisibleRoomBySpaceKey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a way to add room ids for a given space. Needed to make work edition and reply of rooms when displayed in a space (added by a module).