Stabilize screenshot tests from possible left panel width changes#228
Merged
Conversation
Half-Shot
reviewed
Mar 30, 2026
Half-Shot
reviewed
Mar 30, 2026
Half-Shot
approved these changes
Mar 30, 2026
Member
Half-Shot
left a comment
Half-Shot
left a comment
There was a problem hiding this comment.
This seems fine to me. Does the lack of stability mean there is a bug upstream though?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The left panel became 1px wider when I upgraded
react-resizable-panelspackage in EW.The width used here is just what is currently default on EW develop.
The reason to use a separate fixture instead of a screenshot option is that at least on one test (
location.spec.ts), the screenshot never succeeds because playwright does not deem the DOM to have been stabilized.