Simplify the MAS config & allow overriding the Docker image#46
Merged
Conversation
t3chguy
approved these changes
Aug 5, 2025
Member
t3chguy
left a comment
There was a problem hiding this comment.
This is great, but removing so many config options means tests can't override them without having to force types, as we infer the type from the default config. Unless those options have truly gone away should we keep some, e.g. branding?, policy wasm module?
Member
Author
|
@t3chguy Makes sense. We do have a JSON schema for the config, and I can do a one-shot generation for now, WDYT? |
Member
|
Sure! |
Member
Author
|
Have done that in e4d64aa |
sandhose
commented
Aug 5, 2025
t3chguy
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intent is so that we can use the same image update mechanism from the
element-webrepo, so that we regularly pull MAS 'main' and pin it.I've also simplified the initial config to remove most of the 'default' fields
It also re-exports the Postgres testcontainer to make it easier to consume in EW