Add support for disabling spell check#22220
Merged
Merged
Conversation
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
turt2live
requested changes
May 16, 2022
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
this needs a bit of context - there's claims on the linked issues that we can't reasonably manage spell check for mac OS, hence the check.
Evidence to the contrary would be nice :)
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Contributor
Author
The method had a rather unideal name :/ |
turt2live
approved these changes
May 17, 2022
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
bonus points if all the functions here get their public/private/protected declarations
Contributor
Author
|
#22235 :P |
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
SimonBrandner
changed the title
…at/spell-disable Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
turt2live
approved these changes
Jun 26, 2022
t3chguy
approved these changes
Jul 13, 2022
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/matrix-react-sdk#8604
Requires element-hq/element-desktop#379
Notes: none
This change has no change notes, so will not be included in the changelog.