Hide screenshare button in video rooms on Desktop#22810
Merged
robintown merged 2 commits intoJul 12, 2022
Conversation
SimonBrandner
approved these changes
Jul 12, 2022
Contributor
SimonBrandner
left a comment
SimonBrandner
left a comment
There was a problem hiding this comment.
Argh, I didn't realize the order of the buttons mattered - feel free to revert if you found the previous solution clearer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a stopgap solution for https://github.com/vector-im/element-desktop/issues/683, we can hide the screensharing button in video rooms if the platform doesn't support it.
Depends on matrix-org/matrix-react-sdk#9045
Notes: none
(notes handled in the react-sdk PR)
This change has no change notes, so will not be included in the changelog.