element.io defaults for sign in with QR#23491
Closed
hughns wants to merge 1 commit into
Closed
Conversation
develop: - enable showing QR at point of login - enable showing and scanning QR from settings - fallback server configured for when HS doesn't have MSC3886 enabled app: - enable showing QR from settings - no fallback server
Member
|
Needs similar PR for Element Desktop configs - https://github.com/vector-im/element-desktop/ |
3 tasks
Member
|
Given this is touching release instances it should get a product checkmark |
Member
Author
|
The plan is that once other parts of the QR login are more widely available (e.g. server support, better support in iOS/Android), additional capabilities would be opened up on app.element.io. |
Member
Author
|
I've converted this to draft as the short term rollout plan for the QR capability has changed. There is no longer an immediate need for this to be available on *.element.io. |
turt2live
reviewed
Oct 14, 2022
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
Clearing code review while in draft
(also don't forget about element-desktop)
Member
Author
|
I'm closing this as rollout is taking a different approach via matrix-org/matrix-react-sdk#10066 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed behaviour:
app.element.io
Login screens:
No change to login screens.
Settings screens:
If the homeserver doesn't have the support for QR login enabled then settings will look no different from normal:
However, if QR login is enabled on the homeserver (support for MSC3882 and MSC3886) then it would look like this:
develop.element.io
Login screens:
So, at login a new button is visible:
Settings screens:
If the homeserver doesn't support MSC3882 then it will look like normal:
If the homesever does support MSC3882 then it will look like this:
Checklist
Here's what your changelog entry will look like:
✨ Features