Skip to content

Add error notification audio#25312

Merged
weeman1337 merged 1 commit into
developfrom
weeman1337/error-audio
May 10, 2023
Merged

Add error notification audio#25312
weeman1337 merged 1 commit into
developfrom
weeman1337/error-audio

Conversation

@weeman1337
Copy link
Copy Markdown
Contributor

@weeman1337 weeman1337 commented May 9, 2023

should be merged before matrix-org/matrix-react-sdk#10654

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Tasks for the team like planning label May 9, 2023
@weeman1337 weeman1337 marked this pull request as ready for review May 9, 2023 09:52
@weeman1337 weeman1337 requested a review from a team as a code owner May 9, 2023 09:52
@weeman1337 weeman1337 requested review from andybalaam and richvdh May 9, 2023 09:52
Copy link
Copy Markdown
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@richvdh richvdh removed their request for review May 9, 2023 16:53
@weeman1337 weeman1337 merged commit b25a7ef into develop May 10, 2023
@weeman1337 weeman1337 deleted the weeman1337/error-audio branch May 10, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-Task Tasks for the team like planning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants