Display a warning when an unverified user's identity changes#28211
Merged
uhoreg merged 14 commits intoNov 21, 2024
Conversation
uhoreg
requested review from
a team and
richvdh
and removed request for
a team
|
|
uhoreg
force-pushed
the
unverified_user_identity_change_warning
branch
from
ada3de0 to
6fa98f8
Compare
florianduros
requested changes
Oct 21, 2024
Member
There was a problem hiding this comment.
In a first time, we should move UserIdentifyWarning into a functional component and break down its behaviour into multiple hooks. Let me know if you need help to do it
There are differences with the figma design too.
richvdh
reviewed
Oct 21, 2024
Member
Author
|
I think that I've addressed all of @florianduros 's concerns. The test failure looks like possible flakiness, since it's testing components that I haven't touched. |
florianduros
requested changes
Oct 23, 2024
florianduros
requested changes
Oct 24, 2024
Member
florianduros
left a comment
florianduros
left a comment
There was a problem hiding this comment.
It's looking better! Now we can move theses hooks and their logic into separate custom hooks in order to encapsulate their behaviour and make the component easier to maintain.
In test:
- use
jest.spyOnin test to handle the mocking of the client or the crypto api. - use https://testing-library.com/docs/queries/about/ to get the dom element. We want to favour the
rolequery in order to make it sure that we are also accessible - In case of async behaviour when we need to wait for a rerender,
waitForis doing for us the retry/waiting.
richvdh
requested changes
Nov 13, 2024
richvdh
reviewed
Nov 13, 2024
richvdh
reviewed
Nov 18, 2024
| [cli, room, updateCurrentPrompt], | ||
| ); | ||
|
|
||
| // Check if the user's identity needs approval, and if so, add them to the |
Member
There was a problem hiding this comment.
Suggested change
| // Check if the user's identity needs approval, and if so, add them to the | |
| // For each user in the list, check if their identity needs approval, and if so, add them to the |
richvdh
approved these changes
Nov 20, 2024
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Member
Author
|
Strange. One of the tests is now failing in CI, even though I only made a comment change. And I can't reproduce the failure locally. Will need to investigate. |
This was referenced Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-meta#2513
Checklist
public/exportedsymbols have accurate TSDoc documentation.