Revert "Distinguish room state and timeline events when dealing with widgets" (#28681)#29075
Closed
robintown wants to merge 2 commits into
Closed
Revert "Distinguish room state and timeline events when dealing with widgets" (#28681)#29075robintown wants to merge 2 commits into
robintown wants to merge 2 commits into
Conversation
Until we have a matching PR to the Rust SDK that allows Element Call to take advantage of the latest version of MSC2762 in both Element Web and Element X, we should not be using matrix-widget-api v1.12.0. Element Call widgets are too sensitive to the behavior changes introduced in that version, and will just not work.
Member
Author
|
matrix-org/matrix-js-sdk#4647 is related but this PR does not depend on it. |
dbkr
approved these changes
Jan 22, 2025
Member
|
No longer needed. |
Member
Author
|
Didn't end up needing this: Timo worked out a solution in matrix-widget-api that allows us to unbreak EW while keeping compatibility with the Rust SDK. matrix-org/matrix-widget-api#126 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change was introduced to implement the latest version of MSC2762, improving the reliability of room state for Element Call widgets. However, because we're not yet ready with a change to matrix-rust-sdk that would match the behavior of #28681, it turns out that we have to choose between:
Since Element Call's stability was the only reason so far to really push these changes, reverting seems appropriate.