test(backup mas): use checkDeviceIsConnectedKeyBackup instead at looking at the Security & Privacy tab#29146
Merged
Merged
Conversation
florianduros
changed the title
checkDeviceIsConnectedKeyBackup instead at looking at the *Security & Privacy* tabcheckDeviceIsConnectedKeyBackup instead at looking at the Security & Privacy tab
florianduros
force-pushed
the
florianduros/playright-backup-mas
branch
from
b6bd4b7 to
698d72d
Compare
florianduros
force-pushed
the
florianduros/playright-backup-mas
branch
from
698d72d to
dd7dd2c
Compare
…oking at the *Security & Privacy* tab
florianduros
force-pushed
the
florianduros/playright-backup-mas
branch
from
dd7dd2c to
39c7c15
Compare
dbkr
reviewed
Feb 10, 2025
| // Wait for the ui to load | ||
| await expect(page.locator(".mx_MatrixChat")).toBeVisible(); | ||
|
|
||
| // xxx: why the backup key is not in 4S? |
Member
There was a problem hiding this comment.
There is no 4S at this point: recovery hasn't been set up.
Member
Author
There was a problem hiding this comment.
Oh, okay, I'll remove my comment then
dbkr
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.Key backup section will be removed in #29088. Use
checkDeviceIsConnectedKeyBackupto look at the keybackup instead of using the Security & Privacy tab