Skip to content

Log when we show, and hide, encryption setup toasts#29235

Merged
richvdh merged 1 commit into
developfrom
rav/better_toast_logging
Feb 11, 2025
Merged

Log when we show, and hide, encryption setup toasts#29235
richvdh merged 1 commit into
developfrom
rav/better_toast_logging

Conversation

@richvdh
Copy link
Copy Markdown
Member

@richvdh richvdh commented Feb 10, 2025

It's currently hard to debug when someone sees or hides one of these toasts. Lets's add some logging.

It's currently hard to debug when someone sees or hides one of these
toasts. Lets's add some logging.
@richvdh
Copy link
Copy Markdown
Member Author

richvdh commented Feb 10, 2025

Unless anyone has severe objections, I'd like for this to go in the forthcoming release to help us handle the ongoing feedback with these toasts.

@richvdh richvdh added this pull request to the merge queue Feb 11, 2025
Merged via the queue into develop with commit f2fae82 Feb 11, 2025
@richvdh richvdh deleted the rav/better_toast_logging branch February 11, 2025 09:59
@RiotRobot
Copy link
Copy Markdown
Contributor

The backport to staging failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-staging staging
# Navigate to the new working tree
cd .worktrees/backport-staging
# Create a new branch
git switch --create backport-29235-to-staging
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f2fae82e3281b878e5e189534f2edec5ed6a9280
# Push it to GitHub
git push --set-upstream origin backport-29235-to-staging
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-staging

Then, create a pull request where the base branch is staging and the compare/head branch is backport-29235-to-staging.

richvdh added a commit that referenced this pull request Feb 11, 2025
It's currently hard to debug when someone sees or hides one of these
toasts. Lets's add some logging.
github-merge-queue Bot pushed a commit that referenced this pull request Feb 11, 2025
It's currently hard to debug when someone sees or hides one of these
toasts. Lets's add some logging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport staging Label to automatically backport PR to staging branch T-Enhancement X-Release-Blocker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants