Replace focus_room_filter dispatch by Action.OpenSpotlight#29259
Merged
Conversation
…n.OpenSpotlight`
4 tasks
t3chguy
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
focus_room_filteraction and replaces it byAction.OpenSpotlight.focus_room_filteris fired whenKeyBindingAction.FilterRoomsis triggered:element-web/src/components/structures/LoggedInView.tsx
Lines 503 to 508 in 4b9382f
Which is handled by
RoomSearch, to directly open the spotlight:element-web/src/components/structures/RoomSearch.tsx
Lines 27 to 43 in 4b9382f
We can directly ditch
focus_room_filterand opens the spotlight:element-web/src/components/structures/LoggedInView.tsx
Lines 503 to 506 in 1aba639