Remove legacy "checkbox" settings option#29282
Conversation
d6a0a18 to
7935cfb
Compare
7935cfb to
920f2bd
Compare
c0fca5f to
9f90f47
Compare
9f90f47 to
b4c926f
Compare
| // XXX: once design replaces all toggles make this the default | ||
| useCheckbox?: boolean; |
There was a problem hiding this comment.
This seems to suggest moving everything from toggles to checkboxes, what changed?
There was a problem hiding this comment.
I get the feeling this was a choice made a quite a few design iterations ago. I'm assuming since the only bit of settings to ever use checkboxes was the author's own appearance settings. it wasn't ever expanded to the rest of the components.
If the plan is to still change over to checkboxes, we can check with design. However going one way or the other would reduce some overhead here.
There was a problem hiding this comment.
Compound specifically supports both checkboxes and toggles so we should definitely query design which we should favour for what. @element-hq/design
…gsToggleInput with a warning
|
Closing in favor of a fresh PR #30169 |

Based on #29280 (will adjust base branch once merged)
Split out from #29272
This removes a chunk of legacy code which used
forceTooltipVisibleto show some help text for a setting. This was only used by the identity server picker (#29280) and the font family setting. By making the font family setting use the toggle fields instead, this allows for a large chunk of code to be removed (and uses a more standard description field below an input, rather than a tooltip).See diff
Checklist
public/exportedsymbols have accurate TSDoc documentation.