Add key storage toggle to Encryption settings#29310
Merged
Merged
Conversation
richvdh
reviewed
Mar 12, 2025
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
I'm wondering if we should use CryptoEvent.KeyBackupStatus. That said, maybe this is good enough and we should just correct the comments, and move on.
Comment on lines
+195
to
+196
| // of megolm key backup has changed on the user's account (there's no event emitted for megolm | ||
| // key backup enabled state changing, so we use this instead). |
Member
There was a problem hiding this comment.
there's no event emitted for megolm key backup enabled state changing
I don't think that's actually true: isn't CryptoEvent.KeyBackupStatus what you need?
Member
Author
There was a problem hiding this comment.
Yes, not sure why I didn't spot that before. Changed it to use that and all seems to be working nicely.
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
richvdh
approved these changes
Mar 13, 2025
Comment on lines
189
to
192
| // Note that this could potentially update the UI while the user is trying to do something, although | ||
| // if their account data is changing then it implies that they're changing encryption related things | ||
| // on another device. This code is written with the assumption that it's better for the UI to refresh | ||
| // and be up to date with whatever changes they've made. |
Member
There was a problem hiding this comment.
this still talks about account data, which I think is incorrect
Which has gained nowrap due to 917d53a
This was referenced Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#29113 minus a couple of things that got split out
Checklist
public/exportedsymbols have accurate TSDoc documentation.