Mvvm RoomSummaryCard#29674
Merged
florianduros merged 14 commits intoMay 15, 2025
Merged
Conversation
github-actions
Bot
added
the
Z-Community-PR
Member
florianduros
left a comment
florianduros
left a comment
There was a problem hiding this comment.
Good first draft, keep going!
I think this PR is trying to convert two components instead of one: RoomTopic & RoomSummaryCard. Can you make two differents PR for it?
Collaborator
Author
|
@florianduros I moved out the changes about roomTopic into this PR |
MarcWadai
force-pushed
the
29633-mvvm-roomsummarycard
branch
from
d44f319 to
53efede
Compare
MarcWadai
force-pushed
the
29633-mvvm-roomsummarycard
branch
from
53efede to
681be28
Compare
florianduros
approved these changes
Apr 17, 2025
Comment on lines
+91
to
+98
| useEffect(() => { | ||
| for (const [, dmRoomList] of Object.entries(directRoomsList)) { | ||
| if (dmRoomList.includes(room?.roomId ?? "")) { | ||
| setDirectMessage(true); | ||
| break; | ||
| } | ||
| } | ||
| }, [room, directRoomsList]); |
Member
There was a problem hiding this comment.
Should we do setDirectMessage(false) if we can't find the room in the dmRoomList?
Collaborator
Author
There was a problem hiding this comment.
I don't think it is necessary since the state is reinitialized and reloaded for every new roomrummarycard displayed
Member
|
Maybe update the PR description too :) |
MarcWadai
force-pushed
the
29633-mvvm-roomsummarycard
branch
from
681be28 to
4a5df32
Compare
MarcWadai
force-pushed
the
29633-mvvm-roomsummarycard
branch
from
4a5df32 to
e1ca9c5
Compare
MarcWadai
force-pushed
the
29633-mvvm-roomsummarycard
branch
from
e1ca9c5 to
97627d9
Compare
MarcWadai
force-pushed
the
29633-mvvm-roomsummarycard
branch
from
4f6b568 to
3dcc88a
Compare
MarcWadai
force-pushed
the
29633-mvvm-roomsummarycard
branch
from
1ce220a to
99ab741
Compare
snowping
pushed a commit
to Novaloop-AG/element-web
that referenced
this pull request
Jun 22, 2025
* feat: create roomsummarycard viewmodel * feat: use roomsummurycard vm in component * test: jest unit RoomSummaryCard and RoomSummaryCardViewModel * chore: rename to roomsummarycardview * feat: reput room topic without vm * test: roomSummaryCard and roomSummaryCardVM tests * chore: add comments on roomsummarycardVM * fix: merge conflict with roomsummarytopic, and move to vm right_panel * fix(roomsummarycard): remove usetransition for search update * fix: merged file that should be deleted * fix: roomsummurycard not well merge with roomtopic * test: update snapshots
Dileep9999
pushed a commit
to hemanth-nag/element-web
that referenced
this pull request
Oct 8, 2025
* feat: create roomsummarycard viewmodel * feat: use roomsummurycard vm in component * test: jest unit RoomSummaryCard and RoomSummaryCardViewModel * chore: rename to roomsummarycardview * feat: reput room topic without vm * test: roomSummaryCard and roomSummaryCardVM tests * chore: add comments on roomsummarycardVM * fix: merge conflict with roomsummarytopic, and move to vm right_panel * fix(roomsummarycard): remove usetransition for search update * fix: merged file that should be deleted * fix: roomsummurycard not well merge with roomtopic * test: update snapshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task #29633
Mvvm the roomsummarycard that has been split using two VM and moved into subfolder
right_panel:TODO