New room list: avoid extra render for room list item#29752
Merged
florianduros merged 16 commits intoApr 16, 2025
Conversation
florianduros
force-pushed
the
florianduros/new-room-list/avoid-extra-render
branch
from
b7dc8f0 to
df7a618
Compare
florianduros
force-pushed
the
florianduros/new-room-list/avoid-extra-render
branch
from
df7a618 to
4898923
Compare
t3chguy
requested changes
Apr 16, 2025
florianduros
force-pushed
the
florianduros/new-room-list/avoid-extra-render
branch
from
4bbff8a to
a7594fb
Compare
florianduros
force-pushed
the
florianduros/new-room-list/avoid-extra-render
branch
from
f977feb to
a2a83eb
Compare
florianduros
force-pushed
the
florianduros/new-room-list/avoid-extra-render
branch
from
a2a83eb to
57fd820
Compare
florianduros
force-pushed
the
florianduros/new-room-list/avoid-extra-render
branch
from
820b5a6 to
aac97f2
Compare
florianduros
force-pushed
the
florianduros/new-room-list/avoid-extra-render
branch
from
aac97f2 to
b6f7b6b
Compare
florianduros
force-pushed
the
florianduros/new-room-list/avoid-extra-render
branch
from
9d9e9d3 to
63ec957
Compare
Member
Author
|
I followed your suggestion and indeed it's cleaner! |
t3chguy
approved these changes
Apr 16, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
acheong08
pushed a commit
to acheong08/element-web
that referenced
this pull request
Apr 30, 2025
* fix: avoid extra render in the new room list * fix: listen to room name changes * fix: trigger render when notification state change * test: fix room list item tests * chore: fix typo `RoomNotificationState.isUnsentMessage` * refactor: move `isNotificationDecorationVisible` into `useRoomListItemViewModel` * refactor: recalculate notification values on notification state changes * refactor: rename `isNotificationDecorationVisible` to `showNotificationDecoration` * test: add test for room list item view * test: add notification tests in room list item vm * fix: listen to notification updates in `NotificationDecoration` * test: update notification decoration tests * refactor: display notification decoration according to vm * test: update room list item view tests * fix: a11y label computation after room name change * refactor: improve notification handling
snowping
pushed a commit
to Novaloop-AG/element-web
that referenced
this pull request
Jun 22, 2025
* fix: avoid extra render in the new room list * fix: listen to room name changes * fix: trigger render when notification state change * test: fix room list item tests * chore: fix typo `RoomNotificationState.isUnsentMessage` * refactor: move `isNotificationDecorationVisible` into `useRoomListItemViewModel` * refactor: recalculate notification values on notification state changes * refactor: rename `isNotificationDecorationVisible` to `showNotificationDecoration` * test: add test for room list item view * test: add notification tests in room list item vm * fix: listen to notification updates in `NotificationDecoration` * test: update notification decoration tests * refactor: display notification decoration according to vm * test: update room list item view tests * fix: a11y label computation after room name change * refactor: improve notification handling
Dileep9999
pushed a commit
to hemanth-nag/element-web
that referenced
this pull request
Oct 8, 2025
* fix: avoid extra render in the new room list * fix: listen to room name changes * fix: trigger render when notification state change * test: fix room list item tests * chore: fix typo `RoomNotificationState.isUnsentMessage` * refactor: move `isNotificationDecorationVisible` into `useRoomListItemViewModel` * refactor: recalculate notification values on notification state changes * refactor: rename `isNotificationDecorationVisible` to `showNotificationDecoration` * test: add test for room list item view * test: add notification tests in room list item vm * fix: listen to notification updates in `NotificationDecoration` * test: update notification decoration tests * refactor: display notification decoration according to vm * test: update room list item view tests * fix: a11y label computation after room name change * refactor: improve notification handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task https://github.com/element-hq/wat-internal/issues/204
In order to avoid to rerender all the room list item when a room item is selected or if there is a notification, we can add a
memo.We need to listen to the room name and the notification changes to render the correct value.