fix typo in comment and reinstate logging of variables#30231
Merged
Conversation
richvdh
reviewed
Jun 30, 2025
Comment on lines
+411
to
+417
| logSpan.warn("4S is missing secrets", { | ||
| crossSigningReady, | ||
| secretStorageReady, | ||
| allCrossSigningSecretsCached, | ||
| isCurrentDeviceTrusted, | ||
| defaultKeyId, | ||
| }); |
Member
There was a problem hiding this comment.
I somewhat wonder if we should have recoveryDisabled here too, but this is fine
Merged
via the queue into
element-hq:develop
with commit Jun 30, 2025
37df62a
50 of 52 checks passed
Dileep9999
pushed a commit
to hemanth-nag/element-web
that referenced
this pull request
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #30230: the comment referenced the wrong function, and Rich asked to re-add the logging.