Rename the mobile_guide_app_variant config values to be clearer. #30258
Merged
Conversation
Whilst the script should update these if it fails these should link to Element X which is now the default app that we link out to from this page.
Also handle invalid config values by defaulting to Element X.
Member
Author
|
I haven't labeled this as a breaking change seeing as #30172 has only been merged for one day so the change shouldn't actually affect anyone :) |
dbkr
approved these changes
Jul 4, 2025
Dileep9999
pushed a commit
to hemanth-nag/element-web
that referenced
this pull request
Oct 8, 2025
…ment-hq#30258) * Fix the default mobile_guide links. Whilst the script should update these if it fails these should link to Element X which is now the default app that we link out to from this page. * Rename the mobile_guide_app_variant values to be clearer. Also handle invalid config values by defaulting to Element X. * Rename snapshots to match new app variant identifiers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At some stage Element X will be called Element so using
xwas raised as being potentially confusing. This PR makes the following changes:mobile_guide_app_variantconfig values (and the matching MobileAppVariant raw values) reflecting Element X as the defaultelementvariant.