Move the room list to the new ListView(backed by react-virtuoso)#30513
Closed
langleyd wants to merge 40 commits into
Closed
Move the room list to the new ListView(backed by react-virtuoso)#30513langleyd wants to merge 40 commits into
langleyd wants to merge 40 commits into
Conversation
…eyd/memberlist_to_virtuoso
It's more performant and feels less glitchy than the button tooltip moving around when you scroll.
As we have for other icon based buttons in the right panel/app
- As well as stylng cells, set the tabIndex(roving) - Natively focus the div with .focus() so screen reader actually moves over the cells - improve labels and roles
…list looses focus.
…l list. So it isn't erroneously called during onClick of an item.
…eyd/memberlist_to_virtuoso
It looks like it is slightly better center aligned in the new list, as if maybe it was 1 px to high with the old one.
…m/element-web into langleyd/memberlist_to_virtuoso
… account for the separator
… focused. Fixes the issue of not being able to shift+t
- Also remove Space/Enter handing from keyboard navigation we can just leave the default behaviour of those keys and handle via onClick
…ey/use_list_view_with_room_list
Otherwise when changing spaces, the filter does not reset until the next update to the RVS is made.
- Also remove the rest of space/enter keyboard handling use
langleyd
changed the base branch from
develop
to
langleyd/new-room-list/virtuoso
langleyd
changed the base branch from
langleyd/new-room-list/virtuoso
to
develop
…ey/use_list_view_with_room_list
Member
Author
|
Removed in favour of #30515 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.