Avoid flicker of the room list filter on resize#30787
Merged
Merged
Conversation
florianduros
added
T-Defect
backport staging
dbkr
approved these changes
Sep 16, 2025
RiotRobot
pushed a commit
that referenced
this pull request
Sep 16, 2025
* fix: avoid flicker of the room list filter on resize * test: update existing test to render correctly * test: add test to avoid flicker regression (cherry picked from commit 841f12b)
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 16, 2025
* fix: avoid flicker of the room list filter on resize * test: update existing test to render correctly * test: add test to avoid flicker regression (cherry picked from commit 841f12b) Co-authored-by: Florian Duros <florianduros@element.io>
Dileep9999
pushed a commit
to hemanth-nag/element-web
that referenced
this pull request
Oct 8, 2025
…lement-hq#30794) * fix: avoid flicker of the room list filter on resize * test: update existing test to render correctly * test: add test to avoid flicker regression (cherry picked from commit 841f12b) Co-authored-by: Florian Duros <florianduros@element.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30772
The tests need to be updated because when
offsetLeftisn't mocked its value is0. Previously it wasn't considered at wrapping when to sibling elements had the sameoffsetLeft, so without mocking all the list was displayed.