Switch Export and Import Icons to match intuition

[micartey]

Checklist

• I have read through review guidelines and CONTRIBUTING.md.
• Tests written for new code (and old code if feasible).
• New or updated public/exported symbols have accurate TSDoc documentation.
• Linter and other CI checks pass.
• I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

The screenshot above is the current state, but...

• import should be upload (I upload a file)
• export should be download (Export will download a file).

This is how it is usually supposed to be.

This MR will switch the two icons to match that intuition and how other applications do this.

Please have mercy on me... This is my first MR

[andybalaam]

Thanks for the PR!

@aaronraimist do you agree with the PR author that the import and export icons are the wrong way around?

It makes sense to me: export means download to my computer and import means upload from my computer.

[andybalaam]

@micartey looks like you need to regenerate the snapshots so they match what you changed. I think you just need

yarn test -u

to do that but I may be wrong.

[micartey]

@micartey looks like you need to regenerate the snapshots so they match what you changed. I think you just need

yarn test -u

to do that but I may be wrong.

Done!

[dbkr]

The screenshots are from playwright, so it's yarn test:playwright:screenshots

[micartey]

Hi @dbkr,

I tried to run this command but it runs into a timeout. I increase the timeout to 10 minutes but it still timed out.

Therefore, I am unfortunately not able to do this...

[andybalaam]

I am attempting to update the screenshots here and will get back to you.

[andybalaam]

I tried to run this command but it runs into a timeout. I increase the timeout to 10 minutes but it still timed out.

I ran this locally and got some updated screenshots, but I am unable to push to this branch because I am not a maintainer!

@micartey after the timeout did you see updated screenshots in your git working dir? If so, you can push a commit with those updates and we might have got lucky that it's already done what we need.

If not, I guess I have to make a new PR :-(

[dbkr]

Another option is to simply download the 'actual' file from the end to end tests deployment linked above and commit that, which is probably easier if you're only doing one.

[micartey]

I tried to run this command but it runs into a timeout. I increase the timeout to 10 minutes but it still timed out.

I ran this locally and got some updated screenshots, but I am unable to push to this branch because I am not a maintainer!

@micartey after the timeout did you see updated screenshots in your git working dir? If so, you can push a commit with those updates and we might have got lucky that it's already done what we need.

If not, I guess I have to make a new PR :-(

No. There were no files...

But I added you to the list of collaborators so you should be able to commit to the branch in question.

[andybalaam]

Hmm, I still get:

To github.com:micartey/element-web.git
 ! [remote rejected]       micartey/fix/use-correct-icons -> micartey/fix/use-correct-icons (permission denied)
error: failed to push some refs to 'github.com:micartey/element-web.git'

[andybalaam]

OK, chatted to @dbkr IRL this morning, and here is what you can do @micartey .

Download this file https://e2e-30805--matrix-react-sdk.netlify.app/data/287bb09f28144c1843577fab954fbbc8c044bb25.png and replace the file playwright/snapshots/settings/encryption-user-tab/advanced.spec.ts/encryption-details-linux.png with that, and add it to a commit.

How I found this:

• Scrolled up to "github-actions bot deployed to EndToEndTests and clicked "View Deployment"
• Clicked on "Failed" to filter the tests
• Clicked on the "view images" icon under the failing test

[andybalaam]

ftr, I could also have run:

yarn test:playwright:screenshots playwright/e2e/settings/encryption-user-tab/advanced.spec.ts

To generate a new screenshot just for the relevant test.

[micartey]

Thanks @andybalaam for the detailed description!

Figuring out what causes the timeout might be something for another time and issue.
I decently had also issues with the custom screenshot sh script as I am on NixOS and do not have bash in /bin....

Optimizations can be made in the future

[andybalaam]

Thank you @micartey for your patience! I got approval from Design so I will merge when the tests pass.