Implement Playwright tests to ensure calls persist across room switches#31354
Merged
Conversation
BillCarsonFr
approved these changes
Nov 28, 2025
t3chguy
reviewed
Nov 28, 2025
| const pipContainer = page.locator(".mx_WidgetPip"); | ||
|
|
||
| // We should have a PiP container here. | ||
| await expect(pipContainer).toBeVisible(); |
Member
There was a problem hiding this comment.
Looks like this test may be flaky based on the annotation left here by CI
Member
Author
There was a problem hiding this comment.
good spot. Looks like occasionally we get swapped back to the old room after clicking on a room in the room list, more to investigate.
Member
Author
There was a problem hiding this comment.
Put in an extra test on the UI that Element has picked up the video call before we switch rooms, which hopefully prevents it from doing that odd switching behaviour.
t3chguy
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces more Element Call tests, this time using a fake Element Call widget that does just enough to enable PiP. This should be useful enough to know if we're doing things like cleaning up the widgets appropriately.
This will be modified to fail on purpose to test the problem being fixed by #31314
Checklist
public/exportedsymbols have accurate TSDoc documentation.