tweak Fira Code to be a bit smaller to pair better with Inter.#31364
Draft
ara4n wants to merge 1 commit into
Draft
tweak Fira Code to be a bit smaller to pair better with Inter.#31364ara4n wants to merge 1 commit into
ara4n wants to merge 1 commit into
Conversation
Yes, i know i'm going to typography hell for this, but while Fira Code's x-height matches Inter's, in practice it feels way bigger as the pitch is substantially larger. So, to try to make it feel more balanced, we reduce Fira Code's point size to be 95% of Inter's.
Member
Author
|
actually, i'm not sure i can live with myself for doing this; i'll try running with JetBrains Mono for a bit and see how it feels. |
Member
Author
|
Jetbrains Mono feels better than Fira as a pairing, tbh, but i've had to crank it down to 93% to make its pitch similar enough not to jar. |
Member
|
Not sure if this PR is intended to be reviewed yet so marking as draft for now. |
Member
Author
|
yup, it's a draft - sorry. my plan here is to try to fix this for once and for all in compound with design and then propagate things through from there; is on my list of out-of-hours-hacking jobs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yes, i know i'm going to typography hell for this, but while Fira Code's x-height matches Inter's, in practice it feels way bigger as the pitch is substantially larger. So, to try to make it feel more balanced, we reduce Fira Code's point size to be 95% of Inter's.