Fix flaky AppTile tests#31442
Merged
Merged
Conversation
Half-Shot
commented
Dec 5, 2025
robintown
approved these changes
Dec 5, 2025
Member
robintown
left a comment
There was a problem hiding this comment.
Nice, having these tests wait for the loading indicator to be gone looks a lot safer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31439
This is a really fiddly test, but have tried to break it down so it now works:
render(inside theitblocks, as otherwise it's hard to tell the ordering of the various nestedbeforeEachcalls.logger.log("returning theme value");as it was driving me crazy and providing little value.