Skip to content

Fix flaky AppTile tests#31442

Merged
Half-Shot merged 9 commits into
developfrom
hs/fixup-apptile-test-instability
Dec 5, 2025
Merged

Fix flaky AppTile tests#31442
Half-Shot merged 9 commits into
developfrom
hs/fixup-apptile-test-instability

Conversation

@Half-Shot
Copy link
Copy Markdown
Member

Fixes #31439

This is a really fiddly test, but have tried to break it down so it now works:

  • We only call render( inside the it blocks, as otherwise it's hard to tell the ordering of the various nested beforeEach calls.
  • We had places where state was not being reset between tests such as Settings and Widget stores.
  • I removed logger.log("returning theme value"); as it was driving me crazy and providing little value.

@Half-Shot Half-Shot requested a review from a team as a code owner December 5, 2025 16:30
@Half-Shot Half-Shot added the T-Task Tasks for the team like planning label Dec 5, 2025
Copy link
Copy Markdown
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, having these tests wait for the loading indicator to be gone looks a lot safer.

Comment thread test/unit-tests/components/views/elements/AppTile-test.tsx Outdated
Comment thread test/unit-tests/components/views/elements/AppTile-test.tsx Outdated
@Half-Shot Half-Shot enabled auto-merge December 5, 2025 17:21
@Half-Shot Half-Shot added this pull request to the merge queue Dec 5, 2025
Merged via the queue into develop with commit d610c3d Dec 5, 2025
36 checks passed
@Half-Shot Half-Shot deleted the hs/fixup-apptile-test-instability branch December 5, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-Task Tasks for the team like planning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky Jest test: AppTile › for a pinned widget › should render permission request

2 participants