Don't show the key storage out of sync toast when backup disabled#31506
Merged
richvdh merged 1 commit intoDec 10, 2025
Merged
Conversation
andybalaam
approved these changes
Dec 10, 2025
richvdh
added
the
backport staging
Merged
via the queue into
element-hq:develop
with commit Dec 10, 2025
4bd8eeb
47 of 48 checks passed
richvdh
reviewed
Dec 11, 2025
Comment on lines
+443
to
+444
| const backupKeyCached = | ||
| !keyBackupUploadActive || backupDisabled || (await crypto.getSessionBackupPrivateKey()) !== null; |
Member
There was a problem hiding this comment.
this doesn't seem like a good name for this variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If key backup is purposely disabled/inactive, don't treat a missing backup key as the key storage being out of sync.
Fixes #31494
Checklist
public/exportedsymbols have accurate TSDoc documentation.