Skip to content

Mirror local video feed (fixes #2883)#4412

Closed
TheLastProject wants to merge 1 commit into
element-hq:developfrom
TheLastProject:patch-1
Closed

Mirror local video feed (fixes #2883)#4412
TheLastProject wants to merge 1 commit into
element-hq:developfrom
TheLastProject:patch-1

Conversation

@TheLastProject
Copy link
Copy Markdown
Contributor

@TheLastProject TheLastProject commented Jun 25, 2017

Signed-off-by: Sylvia van Os <sylvia@hackerchick.me>

This simply does a CSS transformation on the local video to horizontally mirror it.

@ara4n
Copy link
Copy Markdown
Member

ara4n commented Jul 9, 2017

it's weird - i've never noticed this as a problem. and i think it'd be a bit strange for text to be appear flipped in the local preview. What is the rationale here? Just to make things look more like a mirror? Wouldn't it be better to preview to look as the other user will see you, rather than how you see yourself when you look in the mirror?

(related: excellent explanation of the weirdness of mirrors can be found at http://www.cs.bham.ac.uk/research/projects/cogaff/misc/magic-mirrors.html)

@TheLastProject
Copy link
Copy Markdown
Contributor Author

The idea is indeed to make it more like a mirror because that's the default of all video/camera apps I've ever seen and Riot being the odd one out makes looking at your own video feed rather disorienting.

Try to do basic tasks while looking at your video feed like grabbing something you can see on your local feed. Without this patch, I pretty much always use the wrong arm to try to reach it. I also always move myself to the wrong side if I am not properly centered in the feed and try to center myself or if I try to hold something up to the camera so the other can see. Things like that.

@xuhdev
Copy link
Copy Markdown

xuhdev commented Sep 25, 2017

At least please make this to be an option -- some people seem to want the other way as well.

@lukebarnard1
Copy link
Copy Markdown
Contributor

@TheLastProject would you be willing to make this an optional feature? by adding a setting in UserSettings?

@TheLastProject
Copy link
Copy Markdown
Contributor Author

@lukebarnard1 Probably not something I'll be getting to any times soon as learning Riot's preference system and adding an option is a million times more complex than a single line of CSS and I don't quite have the time to study Riot's codebase that deeply. Surely won't oppose to it being an option though.

@lukebarnard1
Copy link
Copy Markdown
Contributor

In that case, I shall build on this and make it optional.

@lukebarnard1 lukebarnard1 self-assigned this Oct 25, 2017
@lukebarnard1 lukebarnard1 mentioned this pull request Oct 25, 2017
lukebarnard1 added a commit that referenced this pull request Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants