don't cachebust twemoji, so we can dynamically load the right font dialect#9797
Closed
ara4n wants to merge 1 commit into
Closed
don't cachebust twemoji, so we can dynamically load the right font dialect#9797ara4n wants to merge 1 commit into
ara4n wants to merge 1 commit into
Conversation
jryans
requested review from
bwindels and
jryans
and removed request for
a team and
jryans
jryans
requested changes
May 22, 2019
| oneOf: [ | ||
| { | ||
| // allow runtime loading of twemoji (at the expense of cachebusting). | ||
| resource: /TwemojiMozilla.*\.woff2$/, |
Collaborator
There was a problem hiding this comment.
It should be possible to load these fonts in the font manager via require as we do for images in JS, which would allow us to keep the cache busting, and we wouldn't need any changes here.
Collaborator
|
@bwindels's additions to matrix-org/matrix-react-sdk#3008 mean we no longer need this part. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs matrix-org/matrix-react-sdk#3008