This repository was archived by the owner on Oct 22, 2024. It is now read-only.
Implement MSC4142: Remove unintentional intentional mentions in replies#30
Closed
tulir wants to merge 1 commit into
Closed
Implement MSC4142: Remove unintentional intentional mentions in replies#30tulir wants to merge 1 commit into
tulir wants to merge 1 commit into
Conversation
Signed-off-by: Tulir Asokan <tulir@maunium.net>
Member
|
I've pinged product over on the issue to ensure this is what we want. Code look fine though. Thanks! |
Member
|
We have made the decision to merge matrix-react-sdk into https://github.com/element-hq/element-web - if you are still interested in this contribution please move it to that repository. Closing so it does not remain as a zombie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#27291
Implements matrix-org/matrix-spec-proposals#4142
Re-opened version of matrix-org/matrix-react-sdk#12511
The current spec is just a recommendation, so following it is not required and this can be merged already before the MSC is accepted. The goal of the MSC is to remove the dumb recommendation from the spec
For context:
In all cases, new explicit mentions are also of course included