Skip to content

Enable authenticated media by default#17889

Merged
reivilibre merged 12 commits into
developfrom
travis/auth-always-on
Nov 20, 2024
Merged

Enable authenticated media by default#17889
reivilibre merged 12 commits into
developfrom
travis/auth-always-on

Conversation

@turt2live
Copy link
Copy Markdown
Member

@turt2live turt2live commented Oct 30, 2024

Feel free to delay landing this PR as the team sees fit.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@turt2live turt2live requested a review from a team as a code owner October 30, 2024 16:53
@github-actions github-actions Bot deployed to PR Documentation Preview October 30, 2024 16:54 Active
@github-actions github-actions Bot deployed to PR Documentation Preview October 30, 2024 16:57 Active
@github-actions github-actions Bot deployed to PR Documentation Preview October 30, 2024 16:59 Active
@github-actions github-actions Bot deployed to PR Documentation Preview October 30, 2024 17:01 Active
@reivilibre
Copy link
Copy Markdown
Contributor

when we land this, would be good to update the doc to say which version the default changed in

@github-actions github-actions Bot deployed to PR Documentation Preview November 7, 2024 16:58 Active
Comment thread changelog.d/17889.feature
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should shout about this change in the relevant release version's upgrade notes.

@github-actions github-actions Bot deployed to PR Documentation Preview November 18, 2024 16:20 Active
@reivilibre reivilibre self-assigned this Nov 18, 2024
reivilibre added a commit to matrix-org/complement that referenced this pull request Nov 18, 2024
This fixes support with homeservers that enforce authenticated media,
such as Synapse in element-hq/synapse#17889
@github-actions github-actions Bot deployed to PR Documentation Preview November 18, 2024 17:53 Active
@github-actions github-actions Bot deployed to PR Documentation Preview November 19, 2024 10:17 Active
reivilibre added a commit to matrix-org/complement that referenced this pull request Nov 19, 2024
This will be expected to fail when Synapse enforces
authenticated media by default in
element-hq/synapse#17889
@github-actions github-actions Bot deployed to PR Documentation Preview November 19, 2024 10:38 Active
@reivilibre reivilibre force-pushed the travis/auth-always-on branch from fa66b4f to fc5d31c Compare November 19, 2024 11:12
@github-actions github-actions Bot deployed to PR Documentation Preview November 19, 2024 11:13 Active
reivilibre added a commit to matrix-org/complement that referenced this pull request Nov 19, 2024
This will be expected to fail when Synapse enforces
authenticated media by default in
element-hq/synapse#17889
@github-actions github-actions Bot deployed to PR Documentation Preview November 19, 2024 15:49 Active
reivilibre added a commit to matrix-org/complement that referenced this pull request Nov 20, 2024
This fixes support with homeservers that enforce authenticated media,
such as Synapse in element-hq/synapse#17889
reivilibre added a commit to matrix-org/complement that referenced this pull request Nov 20, 2024
These will be expected to fail when Synapse enforces
authenticated media by default in
element-hq/synapse#17889
@reivilibre reivilibre merged commit d0a474d into develop Nov 20, 2024
@reivilibre reivilibre deleted the travis/auth-always-on branch November 20, 2024 14:48
@rollecode
Copy link
Copy Markdown

I just realized this had broken all my images and only swithing it to false fixed things. I don't have knowledge enough to figure out why, but every single URL of my images showed {"errcode":"M_NOT_FOUND","error":"Not found"}. If this is going to be forced always on in the future, I guess I'll never upgrade again. If this is true, all image URLs cause 404.

Why this change and what it does? I'm using synapse-s3-storage-provider, is this taken into account?

@mwnu
Copy link
Copy Markdown

mwnu commented May 18, 2025

#18446

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants