Silently drop PDUs we fail to parse from federation, instead of failing entire transaction#17893
Open
morguldir wants to merge 18 commits into
Open
Silently drop PDUs we fail to parse from federation, instead of failing entire transaction#17893morguldir wants to merge 18 commits into
morguldir wants to merge 18 commits into
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related matrix-org/synapse#7543 / #7543
Complement test: matrix-org/complement#743
Sytest changes: matrix-org/sytest#1391
Pull Request Checklist