Wait for response to be sent#18850
Draft
MadLittleMods wants to merge 1 commit into
Draft
Conversation
Spawning from #18804 (comment)
4 tasks
MadLittleMods
commented
Aug 20, 2025
| Python implementation (rather than the C backend), which is *much* more | ||
| expensive. | ||
|
|
||
| The actual writing of bytes is not finished when this returns. |
Contributor
Author
There was a problem hiding this comment.
Feel like we might want to copy this comment up the chain to respond_with_json and _send_response/_send_error_response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spawning from #18804 (comment) as mentioned by @richvdh,
But we're no longer using(reverted in #18849)LoggingContext.scopesince moving to OpenTracing'sContextVarsScopeManagerin #18849The benefit now is TODO
In terms of tracing, TODO
Dev notes
You can see how I did the simpler implementation of
asyncHTTP resources in https://github.com/element-hq/synapse-small-hosts/pull/313Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.