Export `SYNAPSE_SUPPORTED_COMPLEMENT_TEST_PACKAGES` from `scripts-dev/complement.sh` by MadLittleMods · Pull Request #19208 · element-hq/synapse

MadLittleMods · 2025-11-20T23:22:49Z

Export SYNAPSE_SUPPORTED_COMPLEMENT_TEST_PACKAGES from scripts-dev/complement.sh

This is useful as someone downstream can source the scripts-dev/complement.sh script and run the same set of tests as Synapse:

# Grab the test packages supported by Synapse.
#
# --fast: Skip rebuilding the docker images,
# --build-only: Will only build Docker images but because we also used `--fast`, it won't do anything.
# `>/dev/null` to redirect stdout to `/dev/null` to get rid of the `echo` logs from the script.
test_packages=$(source ${SYNAPSE_DIR}/scripts-dev/complement.sh --fast --build-only >/dev/null && echo "$SYNAPSE_SUPPORTED_COMPLEMENT_TEST_PACKAGES")
echo $test_packages

This is spawning from wanting to run the same set of Complement tests in the https://github.com/element-hq/synapse-rust-apps project.

(Review the diff as a whole)

Todo

Wait for Refactor scripts-dev/complement.sh logic to avoid exit #19209 to be merged

Pull Request Checklist

Pull request is based on the develop branch
Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
- Use markdown where necessary, mostly for code blocks.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
Code style is correct (run the linters)

This is useful so that the script can be sourced by other scripts without exiting the calling subshell (composable). This is split out from #19208 to make easy to understand PR's and build up to where we want to go.

…ages Conflicts: scripts-dev/complement.sh

MadLittleMods · 2025-11-21T17:21:43Z

+  # Export the list of test packages as a space-separated environment variable, so other
+  # scripts can use it.
+  export SYNAPSE_SUPPORTED_COMPLEMENT_TEST_PACKAGES="${test_packages[@]}"


SYNAPSE_SUPPORTED_COMPLEMENT_TEST_PACKAGES the main thing we're adding in this PR.

This is useful as someone downstream can source the scripts-dev/complement.sh script and run the same set of tests as Synapse:

# Grab the test packages supported by Synapse. # # --fast: Skip rebuilding the docker images, # --build-only: Will only build Docker images but because we also used `--fast`, it won't do anything. # `>/dev/null` to redirect stdout to `/dev/null` to get rid of the `echo` logs from the script. test_packages=$(source ${SYNAPSE_DIR}/scripts-dev/complement.sh --fast --build-only >/dev/null && echo "$SYNAPSE_SUPPORTED_COMPLEMENT_TEST_PACKAGES") echo $test_packages

This is spawning from wanting to run the same set of Complement tests in the https://github.com/element-hq/synapse-rust-apps project.

MadLittleMods · 2025-11-21T17:22:05Z

-  if [ -n "$skip_complement_run" ]; then
-      echo "Skipping Complement run as requested."
-      return 0
-  fi


Moved this skip below so all of the exported variables have a chance to actually export

MadLittleMods · 2025-11-21T17:22:38Z

+  )
+
  # It takes longer than 10m to run the whole suite.
-  extra_test_args+=("-timeout=60m")


Can rename back to extra_test_args if desired 🤷

MadLittleMods · 2025-11-22T01:01:59Z

Thanks for the review @anoadragon453 🐍

The team has decided to deprecate and stop publishing python wheels for MacOS. Synapse docker images will continue to work on MacOS, as will building Synapse from source (though note this requires a Rust compiler). Admins using the unstable [MSC2666](matrix-org/matrix-spec-proposals#2666) endpoint (`/_matrix/client/unstable/uk.half-shot.msc2666/user/mutual_rooms`), please check [the relevant section in the upgrade notes](https://github.com/element-hq/synapse/blob/develop/docs/upgrade.md#upgrading-to-v11440) as this release contains changes that disable that endpoint by default. No significant changes since 1.144.0rc1. Admins using the unstable [MSC2666](matrix-org/matrix-spec-proposals#2666) endpoint (`/_matrix/client/unstable/uk.half-shot.msc2666/user/mutual_rooms`), please check [the relevant section in the upgrade notes](https://github.com/element-hq/synapse/blob/develop/docs/upgrade.md#upgrading-to-v11440) as this release contains changes that disable that endpoint by default. - Add experimentatal implememntation of [MSC4380](matrix-org/matrix-spec-proposals#4380) (invite blocking). ([\#19203](#19203)) - Allow restarting delayed event timeouts on workers. ([\#19207](#19207)) - Fix a bug in the database function for fetching state deltas that could result in unnecessarily long query times. ([\#18960](#18960)) - Fix v12 rooms when running with `use_frozen_dicts: True`. ([\#19235](#19235)) - Fix bug where invalid `canonical_alias` content would return 500 instead of 400. ([\#19240](#19240)) - Fix bug where `Duration` was logged incorrectly. ([\#19267](#19267)) - Document in the `--config-path` help how multiple files are merged - by merging them shallowly. ([\#19243](#19243)) - Stop building release wheels for MacOS. ([\#19225](#19225)) - Improve event filtering for Simplified Sliding Sync. ([\#17782](#17782)) - Export `SYNAPSE_SUPPORTED_COMPLEMENT_TEST_PACKAGES` environment variable from `scripts-dev/complement.sh`. ([\#19208](#19208)) - Refactor `scripts-dev/complement.sh` logic to avoid `exit` to facilitate being able to source it from other scripts (composable). ([\#19209](#19209)) - Expire sliding sync connections that are too old or have too much pending data. ([\#19211](#19211)) - Require an experimental feature flag to be enabled in order for the unstable [MSC2666](matrix-org/matrix-spec-proposals#2666) endpoint (`/_matrix/client/unstable/uk.half-shot.msc2666/user/mutual_rooms`) to be available. ([\#19219](#19219)) - Prevent changelog check CI running on @dependabot's PRs even when a human has modified the branch. ([\#19220](#19220)) - Auto-fix trailing spaces in multi-line strings and comments when running the lint script. ([\#19221](#19221)) - Move towards using a dedicated `Duration` type. ([\#19223](#19223), [\#19229](#19229)) - Improve robustness of the SQL schema linting in CI. ([\#19224](#19224)) - Add log to determine whether clients are using `/messages` as expected. ([\#19226](#19226)) - Simplify README and add ESS Getting started section. ([\#19228](#19228), [\#19259](#19259)) - Add a unit test for ensuring associated refresh tokens are erased when a device is deleted. ([\#19230](#19230)) - Prompt user to consider adding future deprecations to the changelog in release script. ([\#19239](#19239)) - Fix check of the Rust compiled code being outdated when using source checkout and `.egg-info`. ([\#19251](#19251)) - Stop building macos wheels in CI pipeline. ([\#19263](#19263)) * Bump Swatinem/rust-cache from 2.8.1 to 2.8.2. ([\#19244](#19244)) * Bump actions/checkout from 5.0.0 to 6.0.0. ([\#19213](#19213)) * Bump actions/setup-go from 6.0.0 to 6.1.0. ([\#19214](#19214)) * Bump actions/setup-python from 6.0.0 to 6.1.0. ([\#19245](#19245)) * Bump attrs from 25.3.0 to 25.4.0. ([\#19215](#19215)) * Bump docker/metadata-action from 5.9.0 to 5.10.0. ([\#19246](#19246)) * Bump http from 1.3.1 to 1.4.0. ([\#19249](#19249)) * Bump pydantic from 2.12.4 to 2.12.5. ([\#19250](#19250)) * Bump pyopenssl from 25.1.0 to 25.3.0. ([\#19248](#19248)) * Bump rpds-py from 0.28.0 to 0.29.0. ([\#19216](#19216)) * Bump rpds-py from 0.29.0 to 0.30.0. ([\#19247](#19247)) * Bump sentry-sdk from 2.44.0 to 2.46.0. ([\#19218](#19218)) * Bump types-bleach from 6.2.0.20250809 to 6.3.0.20251115. ([\#19217](#19217)) * Bump types-jsonschema from 4.25.1.20250822 to 4.25.1.20251009. ([\#19252](#19252))

MadLittleMods added 2 commits November 20, 2025 16:43

Export SYNAPSE_SUPPORTED_COMPLEMENT_TEST_PACKAGES from complement.sh

899fd9f

More robust

b5b3cf7

MadLittleMods mentioned this pull request Nov 20, 2025

Refactor scripts-dev/complement.sh logic to avoid exit #19209

Merged

3 tasks

Add changelog

78e53fe

Merge branch 'develop' into madlittlemods/complement-export-test-pack…

ddc488f

…ages Conflicts: scripts-dev/complement.sh

MadLittleMods commented Nov 21, 2025

View reviewed changes

MadLittleMods added 3 commits November 21, 2025 11:23

Complement should be capitalized

d9540f4

Docker should be capitalized

e2dba3a

Update comment

5236740

MadLittleMods marked this pull request as ready for review November 21, 2025 17:59

MadLittleMods requested a review from a team as a code owner November 21, 2025 17:59

anoadragon453 approved these changes Nov 21, 2025

View reviewed changes

MadLittleMods merged commit 54c93a1 into develop Nov 22, 2025
99 of 103 checks passed

MadLittleMods deleted the madlittlemods/complement-export-test-packages branch November 22, 2025 01:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Export `SYNAPSE_SUPPORTED_COMPLEMENT_TEST_PACKAGES` from `scripts-dev/complement.sh`#19208

Export `SYNAPSE_SUPPORTED_COMPLEMENT_TEST_PACKAGES` from `scripts-dev/complement.sh`#19208
MadLittleMods merged 7 commits into
developfrom
madlittlemods/complement-export-test-packages

MadLittleMods commented Nov 20, 2025 •

edited

Loading

Uh oh!

MadLittleMods Nov 21, 2025

Uh oh!

MadLittleMods Nov 21, 2025

Uh oh!

MadLittleMods Nov 21, 2025

Uh oh!

Uh oh!

MadLittleMods commented Nov 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

MadLittleMods commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Todo

Pull Request Checklist

Uh oh!

MadLittleMods Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

MadLittleMods Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

MadLittleMods Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MadLittleMods commented Nov 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MadLittleMods commented Nov 20, 2025 •

edited

Loading