Skip to content

SourceRow: create accent colors for screen #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danirabbit wants to merge 2 commits into
base: master
Choose a base branch
from
+40 −8
Open

SourceRow: create accent colors for screen #931

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d847de3
SourceRow: create accent colors for screen
danirabbit Feb 26, 2026
74ead8a
Merge branch 'master' into danirabbit/sourcerow-styleforscreen
danirabbit Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 40 additions & 8 deletions src/Widgets/SourceRow.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ public class Calendar.SourceRow : Gtk.ListBoxRow {
private Gtk.Label message_label;
private Gtk.CheckButton visible_checkbutton;

private static Gee.HashMap<string, Gtk.CssProvider>? providers;

public SourceRow (E.Source source) {
this.source = source;

Expand Down Expand Up @@ -58,7 +60,7 @@ public class Calendar.SourceRow : Gtk.ListBoxRow {
}
});

style_calendar_color (cal.dup_color ());
set_accent_color (cal.dup_color ());

delete_button = new Gtk.Button.from_icon_name ("edit-delete-symbolic", MENU) {
sensitive = source.removable,
Expand Down Expand Up @@ -125,16 +127,46 @@ public class Calendar.SourceRow : Gtk.ListBoxRow {
source.changed.connect (source_has_changed);
}

private void style_calendar_color (string color) {
var css_color = "@define-color accent_color %s;".printf (color.slice (0, 7));
private void set_accent_color (string? color) {
if (color == null) {
/* We automatically use the accent color */
return;
}

var style_provider = new Gtk.CssProvider ();
var color_class = color.replace ("#", "color-");
// FIXME: in GTK4 use css_classes to make sure we remove old ones
visible_checkbutton.get_style_context ().add_class (color_class);

if (providers == null) {
providers = new Gee.HashMap<string, Gtk.CssProvider> ();
Copy link
Member

@leolost2605 leolost2605 Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could put this in a static construct or just assign in the declaration, i.e.
private static Gee.HashMap<string, Gtk.CssProvider> providers = new Gee.HashMap<string, Gtk.CssProvider> ();

}

if (providers.has_key (color)) {
return;
}

var bg_rgba = Gdk.RGBA ();
bg_rgba.parse (color);

string style = @"
checkbutton:checked.$color_class check {
background-color: $color;
-gtk-icon-shadow: 0 1px 1px shade($color, 0.7);
}
";

var style_provider = new Gtk.CssProvider ();
try {
style_provider.load_from_data (css_color, css_color.length);
visible_checkbutton.get_style_context ().add_provider (style_provider, Gtk.STYLE_PROVIDER_PRIORITY_APPLICATION);
style_provider.load_from_data (style);

providers[color] = style_provider;
Gtk.StyleContext.add_provider_for_screen (
Gdk.Screen.get_default (),
providers[color],
Gtk.STYLE_PROVIDER_PRIORITY_APPLICATION
);
} catch (Error e) {
warning ("Could not create CSS Provider: %s\nStylesheet:\n%s", e.message, css_color);
critical ("couldn't set source check color: %s", e.message);
}
}

Expand All @@ -144,7 +176,7 @@ public class Calendar.SourceRow : Gtk.ListBoxRow {

E.SourceCalendar cal = (E.SourceCalendar)source.get_extension (E.SOURCE_EXTENSION_CALENDAR);

style_calendar_color (cal.dup_color ());
set_accent_color (cal.dup_color ());

visible_checkbutton.active = cal.selected;
}
Expand Down
Loading