Show symbol outline pane on right of document

[jeremypw]

Fixes #1033

• Move outline code into main code and remove the plugin
• Show outline to the right of the document with matching background
• Add preference option to show outline
• Add action to toggle outline visiblity (<Alt>\)
• RemoveDocument signal (doc_saved ()) that was only used by the plugin

[jeremypw]

[jeremypw]

@danrabbit I would appreciate your advice as to how to get the symbol list (which is a Granite.Widgets.SourceList) to follow the styling of the document wrt background and text color.

[cassidyjames]

@jeremypw it is probably worth looking at and adapting this method, as setting the background to @tab_base_color seems to get us most of the way there:

code/src/Widgets/DocumentView.vala

Lines 100 to 121 in 16d7716

	private void update_inline_tab_colors () {
	var sssm = Gtk.SourceStyleSchemeManager.get_default ();
	var style_scheme = Scratch.settings.get_string ("style-scheme");
	if (style_scheme in sssm.scheme_ids) {
	var theme = sssm.get_scheme (style_scheme);
	var text_color_data = theme.get_style ("text");
	// Default gtksourceview background color is white
	var color = "#FFFFFF";
	if (text_color_data != null) {
	// If the current style has a background color, use that
	color = text_color_data.background;
	}
	var define = "@define-color tab_base_color %s;".printf (color);
	try {
	style_provider.load_from_data (define);
	} catch (Error e) {
	critical ("Unable to set inline tab styling, going back to classic notebook tabs");
	}
	}
	}

Perhaps renaming that method and defining a GTK CSS variable called @themed_bg or something could work, then we could use that in the various places we want to use that color?

[jeremypw]

@cassidyjames Thanks for the suggestion! I'll try that.

[jeremypw]

@cassidyjames Implemented your suggestion - thanks.

[danirabbit]

If we're moving this anyways, can we make it not be a plugin and just have it be part of the app?

I wonder if we should also add a menuitem to toggle its visibility like we have with the sidebar

[jeremypw]

Yes, it should not be too hard to move the code into a "SymbolOutline" subfolder of \src and bypass the plugin interface. As you say, an alternative way of toggling it will be needed.

[jeremypw]

The latest commit moves the outline code to the /src. Note that you should run it as a flatpak as it is not compatible with the existing plugin code. Otherwise you will need to delete the outline plugin from /usr/lib/x86_64-linux-gnu/io.elementary.files/plugins.

Should I include code to blacklist/overwrite the outline plugin in the same way as I did in #1151?

[jeremypw]

I have taken the opportunity to DRY the code to reduce duplication between the Vala and C outliners.

[jeremypw]

Need to fix some regressions.

[jeremypw]

I have added code to overwrite the old plugin when not installed as Flatpak in order to make development and testing easier. This can easily be reverted if considered unnecessary.

[jeremypw]

Removed "blacklist" code as it was not needed when the strip-trailing-spaces plugin was moved into main code.

[danirabbit]

Looks like there's a completely commented file: src/SymbolPane/meson.build

Otherwise, works as expected and looks good!