New Window: do not restore docs, do not duplicate projects#1144
New Window: do not restore docs, do not duplicate projects#1144
Conversation
|
Should probably make "New Window" an app action but that can be left to another PR. |
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Functionally this works for me, I have one comment about if we need this method on the application class
|
Hmm, I guess I always considered the Application class to be responsible for creating and managing windows. But in this case the Application class does not do anything other than create the window so I guess it does not need to be there. I'll check if there are any drawbacks in moving it. |
|
@danrabbit I have taken the opportunity to simplify window creation a little. |
| title: _("Code") | ||
| ); | ||
|
|
||
| document_view.realize.connect (() => { |
There was a problem hiding this comment.
Is there a reason you moved this to the constructor? I think usually we don't want to have things here unless they are actually specific to this constructor as opposed to construct which runs for all constructors
There was a problem hiding this comment.
I moved it here because it uses restore_docs which is not available in construct (afaik)
|
Closing as too many changes since this was proposed. |
3 participants
Fixes #1140
Fixes #1141 (bitesize)