Closed
Conversation
jeremypw
requested changes
Feb 8, 2022
Collaborator
jeremypw
left a comment
There was a problem hiding this comment.
Sorry for not reviewing this sooner - this is some good work. Ignoring code style issues for now, here are some issues I've noticed:
- The search dialog shows on pressing the shortcut even if there are no projects loaded.
- The search results are not disambiguated where there are more than one project loaded
- Clicking on a search result does not load the file (need to press Enter)
- The search is a bit too fuzzy for my liking - some apparently poor matches appear before good or exact matches. It might be better to start with a simpler search i.e. only showing files with basenames starting with the typed letters. Later PR maybe could show different levels of match in different categories in a similar way to Files search.
- I wonder whether it would be possible to incorporate filename search into the existing global text search function, or piggyback on it somehow. Both iterate through project files. It would then be unnecessary to create a new plugin.
|
Hello @treagod , Are you still working on this? I'd be glad to help if you need to. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a fuzzy search to solve #134.
I adapted the fuzzy search from this blog and integrated it into a modal, which can be opened with Ctrl+p,
For now I want to implement the search as a plugin so that the user can opt-in as long the fuzzy search is not mature enough - but I think in the long run this functionality should be part of the core of the editor.