Follow system style toggle#1192
Closed
Oowoosh0 wants to merge 9 commits intoelementary:masterfrom
Oowoosh0:system-style-switch
Closed
Follow system style toggle#1192Oowoosh0 wants to merge 9 commits intoelementary:masterfrom Oowoosh0:system-style-switch
Oowoosh0 wants to merge 9 commits intoelementary:masterfrom
Oowoosh0:system-style-switch
Conversation
Collaborator
|
There needs to be some padding between the new switch and it label. |
jeremypw
requested changes
May 30, 2022
Collaborator
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
The code looks clean to me and works as expected. Just some padding required between the switch and the label. Needs input from design team as well.
Collaborator
|
Although the UI closely follows the corresponding Terminal PR (#666) there is a significant difference in behaviour. Terminal persists the user preference when the "follow-system-style" is toggled - i.e. the original appearance is restored when the switch is toggled off. This PR does not persist the original setting but overwrites it. I think Terminal's behaviour is better. |
Member
|
Closing since this has conflicts and OP hasn't responded in 2 months |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #902
Adds a follow system style toggle to the preference menu as mentioned in #902
Default is off, if enabled Code follows the global dark style setting.
It uses solarized-light for syntax highlighting if follow system style is set to true and system style is set to default. So currently there is no way to use the classic theme for syntax highlighting while having follow system style enabled. But to make that possible one would have to separate the choice of color scheme for syntax highlighting and gtk dark style.