Skip to content

Set search entry icon and styleclass according to results#1285

Merged
danirabbit merged 11 commits intomasterfrom
search-entry-classes
Mar 28, 2023
Merged

Set search entry icon and styleclass according to results#1285
danirabbit merged 11 commits intomasterfrom
search-entry-classes

Conversation

@jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Mar 16, 2023

Consolidate setting of search entry icon and styleclass with updating other search widgets

@danirabbit
Copy link
Member

@jeremypw can you resolve conflicts here please :)

Jeremy Wootten added 2 commits March 25, 2023 16:59
@jeremypw jeremypw marked this pull request as ready for review March 26, 2023 10:28
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple inline comments

@jeremypw jeremypw requested a review from danirabbit March 28, 2023 10:05
@jeremypw jeremypw dismissed danirabbit’s stale review March 28, 2023 10:07

Requested changes made

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@danirabbit danirabbit enabled auto-merge (squash) March 28, 2023 16:18
@danirabbit danirabbit merged commit dc7b1a6 into master Mar 28, 2023
@danirabbit danirabbit deleted the search-entry-classes branch March 28, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants