Skip to content

Expose fuzzy find function and accelerator in sidebar action menu#1395

Merged
colinkiama merged 5 commits intofuzzy-finderfrom
fuzzy-finder-menuitem
Jan 4, 2024
Merged

Expose fuzzy find function and accelerator in sidebar action menu#1395
colinkiama merged 5 commits intofuzzy-finderfrom
fuzzy-finder-menuitem

Conversation

@jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Jan 4, 2024

  • Improves the discoverability of the plugin a little by adding a menu item to the folder manager action menu when it is active. DRY shared code.
  • Consistently use "Find Project Files" to describe function
  • Move the SearchProject class out of the main plugin file and into its own file for clarity.

@jeremypw jeremypw requested a review from colinkiama January 4, 2024 17:21
@jeremypw
Copy link
Collaborator Author

jeremypw commented Jan 4, 2024

The UX of this function can be revisited should it be promoted to the main code.

Copy link
Contributor

@colinkiama colinkiama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@colinkiama colinkiama merged commit 0c1fba8 into fuzzy-finder Jan 4, 2024
@colinkiama colinkiama deleted the fuzzy-finder-menuitem branch January 4, 2024 18:34
jeremypw added a commit that referenced this pull request Jan 10, 2024
* Added a fuzzy search modal

* Fixed indent

* Use accent color for selection

* Listen to git change

* Use async fuzzy finder and ignore paths from .gitignore

* Resize dialog

* Added scrolling by up/down arrows

* Check project content on each search to get all changes

* Add basic debouncing and cancellation for each search query

* Add cancellable checks to all loops during fuzzy search

* Increase fuzzy search results update speed

* Fix long delay before fuzzy finder dialog opens

- Fuzzy finder paths indexed when plugin is activated
- Fuzy finder dialog now opens instantly

* Fix vala-lint errors in fuzzy-search plugin directory

* Prevent fuzzy search dialog from opening if there are no projects opened

* Clicking on fuzzy search results loads the clicked result

* Fuzzy search results across multiple projects are disambiguated using the project name before file path

* Update fuzzy search debug logs

* Improve Fuzzy Search Accuracy

- Combine file name and file paths in fuzzy finder

* Ignore dot-prefixed directories in fuzzy search

* Update debug messaging for fuzzy search

* Fix code style warnings in fuzzy search plugin

* Update license and copyright info for Fuzzy Finder plugin

* Add end method to project path parsing async call

* Fix vala-lint errors

* Improve fuzzy matching

- Fix issue how matches are added to list of matches
- Stop using a combined score. Prefer filename based matches when available
- Stop including directory separator in separator bonus

* Change fuzzy search keyboard shortcut to 'ALT + F'

* Remove unused GitManager signals

* Files that cannot be opened in Code are filtered out of fuzzy search

* Render fuzzy search items with list boxes

* Add mouser hover styling to fuzzy search items

* Handle Fuzzy Search key presses with EventControllerKey

* Now using popover to show fuzzy search

* Add title label to fuzzy search popover

* Remove unused window size and positining code

* Prevent focus on fuzzy item results

* Fuzzy search results for current project are prioritised

* Expose fuzzy find function and accelerator in sidebar action menu (#1395)

* Add Fuzzy Find menuitem to sidebar

* Consistently use "Find Project Files"

* Move SearchProject to separate file

* Fix lint

* Remove menuitem on deactivation of "Find Project Files" plugin

* Associate popover with foldermanager (#1396)

* Associate popover with foldermanager
* Remove deprecated PopoverConstraint

* Add folder_item_change plugin manager hook in preparation for background indexing

* Allow search project parsing to be cancellable

* Create indexer and add methods for adding and removing files and directories to search project class

* Use fuzzy search indexer for fuzzy search results

* Update indexer debug logs

* Update license info and comments in Fuzzy Search Project

* Remove old fuzzy search indexer testing logs

---------

Co-authored-by: Marvin Ahlgrimm <marv.ahlgrimm@gmail.com>
Co-authored-by: Jeremy Wootten <jeremywootten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants