Enhance vim emulation commands#633
Closed
mcclurgm wants to merge 18 commits intoelementary:masterfrom
Closed
Conversation
Collaborator
|
Probably best reviewed by a Vim (plugin) user. Code style looks OK. |
Collaborator
|
@mcclurgm Need to fix lint error (trailing whitespace). |
Contributor
Author
|
Sorry I haven't been keeping up on this. I'm working on starting to break it up into a collection of smaller, focused PRs as you requested. I've also realized issues with some of the changes in this PR (for example, moving up or down resets to the end of the line), so I think it's probably safe to discard it and I'll reimplement the changes with fixed behavior. |
Collaborator
|
@mcclurgm OK, thanks. I'll close for now. |
This was referenced Mar 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Started as a fix for my issue #614.
It implements 2 new commands, lower-case "a" to insert after cursor and caret "^" to move to beginning of the indented line.
It also updates the behavior of other commands to use paragraph ends instead of display line ends, like vim does, to be more predictable.
It's a work in progress at the moment, I expect to add more stuff going forward. All my changes should be independent so you can only merge the ones you want.