Close Open Documents from folder when closing folder#833
Closed
franciol wants to merge 9 commits intoelementary:masterfrom
Closed
Close Open Documents from folder when closing folder#833franciol wants to merge 9 commits intoelementary:masterfrom
franciol wants to merge 9 commits intoelementary:masterfrom
Conversation
Fixes elementary#576 Fixes elementary#576
jeremypw
requested changes
Jul 1, 2020
Collaborator
jeremypw
left a comment
There was a problem hiding this comment.
Thanks for your first contributon to Code!
This works OK for the simple case where there is one view and it has documents in it and the approach makes sense. However, there are issues with some corner cases as noted inline.
- If there is a split view and the wrong view is focused then the project folders do not get closed
- If there are no documents open and the welcome view is showing then closing a project folder produces a spurious blank view.
Collaborator
Collaborator
|
@tintou Do have any comments for this? |
Collaborator
|
Seems to have acquired a build - problem - investigating. |
Collaborator
|
@franciol This PR needs updating due to changes in master (which merging did not fix). Are you in a position to return this PR to working order? |
Closed
Collaborator
|
Closed in favour of #912 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #576
FileView sends a signal to MainWindow so it can verify if there's an open file from that folder.
MainWindow then closes all docs open from that folder.