Conversation
jeremypw
changed the title
jeremypw
changed the title
# Conflicts fixed: # src/Application.vala
jeremypw
changed the title
jeremypw
changed the title
zeebok
approved these changes
Mar 12, 2025
lenemter
added a commit
that referenced
this pull request
Aug 16, 2025
…e in fileoperations (#2616) Fixes #2615 After #2268 files being copied or dragged have their name sanitized before being given to the recipient so that they appear correctly when pasted/dropped as text. However, they were not being re-escaped when used in a file operation and this caused the operation to fail for some files. This PR fixes that. After this PR, copy/dragging a file should work both to a text document or terminal and to another folder in Files (or Dolphin or Nautilus at least). Note that Dolphin does not unescape filenames when transferred as text but Nautilus does. Co-authored-by: Leo <lenemter@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #664
First commit (fix quotes)
Second commit (fix protocol for DND)
file://will be included by using explicit parameters forsanitize_path. To avoid unexpected regressions the existing default parameter is kept except in relation to fixing this problem.With this PR, dragging a file item into a text target and copy/pasting it into a text target both cause a quoted url to be inserted.
There is still a difference between DND and Copy/Paste in that the former always includes the protocol whereas the latter the removes the protocol if it is "file://". This is because the item might be dropped on a target where the protocol is needed. It is up to the target to format the received text according to its needs.