Ensure scroll controller only active when <Control> pressed#2513
Merged
Conversation
alainm23
approved these changes
Nov 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2512
The issue was caused by the dialog thrown when permanently deleting an item using the keyboard causing the "key-release" signal being swallowed. This resulted in the scroll controller that handles zooming remaining active and blocking the native scroll handler.
This is all because of a "feature" of the Gtk3 scroll controller which always swallows scroll events so needs to be switched on and off to avoid blocking the native scroll controller. This should become unnecessary in Gtk4.
This PR makes the zoom scroll handler turn itself off if it gets triggered unexpectedly.