LocationBar: Correctly handle admin:// protocol; show warning#2528
Merged
LocationBar: Correctly handle admin:// protocol; show warning#2528
admin:// protocol; show warning#2528Conversation
tintou
approved these changes
Feb 4, 2025
Member
tintou
left a comment
tintou
left a comment
There was a problem hiding this comment.
Looks like the right path forward!
Contributor
Author
|
I'll merge now - the appearance can be tweaked later if required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2524
Fixes #1844
Partially resolves #165
This PR depends on, and incorporates, #2522. Without that fix it is not possible to manually enter an
admin://url.Further refinements are possible such as supplying menu action/hotkey/bookmark for opening a location as admin without having to type in the pathbar but that will be left for subsequent PRs.