Jeremypw/gtk4prep/devicelistbox cleanup#2541
Merged
danirabbit merged 6 commits intomainfrom Mar 8, 2025
Merged
Conversation
danirabbit
approved these changes
Mar 8, 2025
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Same little question/nitpick as the other one, otherwise makes sense to me
src/View/Sidebar/DeviceListBox.vala
Outdated
Comment on lines
+176
to
+177
| int index = 0; | ||
| Gtk.ListBoxRow? row = list_box.get_row_at_index (index++); |
Member
There was a problem hiding this comment.
Same question as another review. It seems odd to me to start at 0 and then immediately increment
Contributor
Author
There was a problem hiding this comment.
Now using prefix operator which is clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use equivalent code that also compiles in Gtk4 where possible