Simple syntax changes#2553
Conversation
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Mostly straightforward, just a few comments
Co-authored-by: Danielle Foré <danielle@elementary.io>
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
You resolved the one with removing show_all where it should be present but there's a bunch of other ones in this diff where a window or dialog is using show_all and if you just remove it then the window will never be shown
|
Sorry - I overlooked dialogs need to be shown whereas other widgets you can just delete |
|
I have pushed another PR applying the dialog fixes to the main branch where possible. |
| var grid = new Gtk.Box (VERTICAL, 0); | ||
|
|
||
| grid.append (header); | ||
| grid.append (new Gtk.Separator (Gtk.Orientation.HORIZONTAL)); | ||
| grid.append (chooser); | ||
| grid.append (new Gtk.Separator (Gtk.Orientation.HORIZONTAL)); | ||
| grid.append (choices_box); | ||
| // grid.append (action_box); | ||
| child = grid; |
There was a problem hiding this comment.
While we're here, can we rename this to box since it isn't a grid anymore :p
| window.title = "Files Portal Tester"; | ||
|
|
||
| var grid = new Gtk.Grid () { | ||
| var grid = new Gtk.Box (VERTICAL, 6) { |
There was a problem hiding this comment.
We removed Portaltester in another branch so I guess this needs to be rebased?
libcore/AbstractSlot.vala
Outdated
| // content_box.pack_start (overlay, true, true, 0); | ||
| // overlay.add (widget); | ||
| overlay = new Gtk.Overlay () { | ||
| child = widget |
There was a problem hiding this comment.
pack_start had true for expand so I think we need to add hexpand = true and vexpand = true
|
|
||
| lside_pane = new Gtk.Paned (Gtk.Orientation.HORIZONTAL) { | ||
| // expand = true, | ||
| hexpand = true, |
…le-syntax # Conflicts fixed: # filechooser-portal/tests/PortalTester.vala # libcore/AbstractSlot.vala # libcore/FileUtils.vala # src/View/DirectoryNotFound.vala # src/View/Window.vala
2 participants
Assorted simple changes mainly to accomodate changes in syntax. These changes should not have any functional effect.