Merged
Conversation
Contributor
|
I thought I had already rewritten this somewhere avoiding getting the number of children but I can't seem to locate it atm. If I can't find it I'll do it again. |
Contributor
|
As we only add rows in one place and never remove them, the simplest solution is to just count them as they are added. Using a model would be more elegant if rows are added and removed adhoc. |
jeremypw
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no more
ListBox.get_children ()in GTK4There's one place I didn't replace here and it's the block starting at line 154. I suppose we could iterate over the list and add to a counter to get the number of children? Alternatively if we switched this whole thing to use a ListModel we could get the number of items in the model, but we'd need to add a "new_name" property to
Files.File. Thoughts @jeremypw?