Gtk4 Prep - Use dialog.response.connect () pattern#2568
Merged
danirabbit merged 1 commit intomainfrom Mar 23, 2025
Merged
Conversation
danirabbit
approved these changes
Mar 23, 2025
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
I don't think present is main loop blocking in GTK4, so we'll need to do something else still in the future for those cases. But this does get us a bit closer I think so 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dialog response is consistently handled in a closure connected to the
responsesignal.Where possible dialog.present () is also used but it seems that in Gtk3, this does not block the main loop even if the dialog is flagged as modal. In cases where we need the mainloop to wait for a result from the dialog,
dialog.run ()is still called. I assume that in Gtk4, this can be changed todialog.present ()and themodalflag will be observed.